small virtio serial update #11841
Merged
small virtio serial update #11841
+49
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
jyao1 and
mikebeaton
apop5
reviewed
Dec 4, 2025
Member
|
Please describe these changes in terms of the 'why' - describing /what/ a 2 line patch does is kind of pointless, anybody can see that for themselves. |
Left over from development. The messages do not serve much value and spam the logs. Drop them. Signed-off-by: Gerd Hoffmann <[email protected]>
The function does not return any flags. Make that explicit instead of leaving the return value unmodified, so we do not depend on the caller initializing it. Signed-off-by: Gerd Hoffmann <[email protected]>
Next patch needs this function. No functional change. Signed-off-by: Gerd Hoffmann <[email protected]>
kraxel
force-pushed
the
devel/logs-virtio-serial
branch
from
680646e to
18ef1af
Compare
Pull Request Formatting IssuesAddress these issues and the validation will automatically re-run when you update your pull request. |
Check if there is data available for read, set the EFI_SERIAL_INPUT_BUFFER_EMPTY flag accordingly. With proper status returned VirtioSerialIoRead() will only be called if there is actual data to read, so we must call VirtioSerialIoWriteFlush() to make sure pending writes get flushed to the host properly. Signed-off-by: Gerd Hoffmann <[email protected]>
kraxel
force-pushed
the
devel/logs-virtio-serial
branch
from
18ef1af to
0d8d6b0
Compare
Member
Author
|
@ardbiesheuvel Seems without approval the push label has no effect. |
ardbiesheuvel
approved these changes
Dec 9, 2025
Merge Queue Status✅ The pull request has been merged at 639b2a6 This pull request spent 20 minutes 50 seconds in the queue, including 20 minutes 41 seconds running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OvmfPkg/VirtioSerialDxe: drop Get/SetControl logging
OvmfPkg/VirtioSerialDxe: explitly clear return value in GetControl
OvmfPkg/VirtioSerialDxe: factor out VirtioSerialIoWriteFlush
OvmfPkg/VirtioSerialDxe: set EFI_SERIAL_INPUT_BUFFER_EMPTY
Breaking change?
Impacts security?
Includes tests?
How This Was Tested
manual testing in qemu
Integration Instructions
N/A